On (24/06/13 08:04), Jisheng Zhang wrote: > commit 42e99bd975fd ("zram: optimize memory operations with > clear_page()/copy_page()") optimize page copy/clean operations, but > then commit d72e9a7a93e4 ("zram: do not use copy_page with non-page > aligned address") removes the optimization because there's memory > corruption at that time, the reason was well explained. But after > commit 1f7319c74275 ("zram: partial IO refactoring"), partial IO uses > alloc_page() instead of kmalloc to allocate a page, so we can bring > back the optimization. > > commit 80ba4caf8ba9 ("zram: use copy_page for full page copy") brings > back partial optimization, missed one point in zram_write_page(). > optimize the full page copying in zram_write_page() with copy_page() Is copy_page() really more optimal than memcpy(PAGE_SIZE)?