Re: [PATCH 04/11] block: remove the blk_integrity_profile structure

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Jun 08, 2024 at 12:01:43AM +0530, Kanchan Joshi wrote:
> > +	if (!bi || bi->csum_type != BLK_INTEGRITY_CSUM_NONE) {
> >   		ti->error = "Integrity profile not supported.";
> >   		return -EINVAL;
> 
> I'd rename BLK_INTEGRITY_CSUM_NONE to BLK_INTEGRITY_CSUM_NOP. Overall.

Well, we don't do any checksumming here, and not a no-op checksum.
So in terms of the checksum field I think the name is correct.  But
it is indeed confusing vs the format string, but that is an ABI
we can't change..





[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux