On Tue, Apr 18, 2017 at 02:07:53PM +0000, Bart Van Assche wrote: > Hello Johannes, > > Thanks for the review. But are you aware that with the current content an > include guard is overkill because it is safe to evaluate the "extern unsigned > long rd_size" declaration multiple times? Yes I am. But once someone does changes to this header and forgets the include guard as well it may cause errors. I am aware that this is rather cosmetic than needed, that's why I declared it as a nit. Byte, Johannes -- Johannes Thumshirn Storage jthumshirn@xxxxxxx +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
