On Wed, Jun 05, 2024 at 04:52:27PM +0200, Milan Broz wrote: > On 6/5/24 8:28 AM, Christoph Hellwig wrote: >> Use the block layer built-in nop profile instead of reinventing it. > > As this is my "invention", I am pretty sure that "nop" profile was > not available at the time I was prototyping AEAD dmcrypt extension. > (It was months before we submitted it upstream - and then nobody > apparently fixed it.) Looking at the history the nop profile was moved from nvme to common code to also support btt in 2015, dm-integrity was added in 2017. So maybe you just missed it. Anyway, I'm also happy to tone this down a bit, it sounds a bit too aggressive..
