Re: [PATCH 07/12] block: use kstrtoul in flag_store

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Christoph Hellwig <hch@xxxxxx>, Jens Axboe <axboe@xxxxxxxxx>, "Martin K. Petersen" <martin.petersen@xxxxxxxxxx>
Subject: Re: [PATCH 07/12] block: use kstrtoul in flag_store
From: Chaitanya Kulkarni <chaitanyak@xxxxxxxxxx>
Date: Thu, 6 Jun 2024 00:16:38 +0000
Accept-language: en-US
Cc: Mike Snitzer <snitzer@xxxxxxxxxx>, Mikulas Patocka <mpatocka@xxxxxxxxxx>, Song Liu <song@xxxxxxxxxx>, Yu Kuai <yukuai3@xxxxxxxxxx>, Dan Williams <dan.j.williams@xxxxxxxxx>, Vishal Verma <vishal.l.verma@xxxxxxxxx>, Dave Jiang <dave.jiang@xxxxxxxxx>, Ira Weiny <ira.weiny@xxxxxxxxx>, Keith Busch <kbusch@xxxxxxxxxx>, Sagi Grimberg <sagi@xxxxxxxxxxx>, Chaitanya Kulkarni <chaitanyak@xxxxxxxxxx>, "linux-block@xxxxxxxxxxxxxxx" <linux-block@xxxxxxxxxxxxxxx>, "dm-devel@xxxxxxxxxxxxxxx" <dm-devel@xxxxxxxxxxxxxxx>, "linux-raid@xxxxxxxxxxxxxxx" <linux-raid@xxxxxxxxxxxxxxx>, "nvdimm@xxxxxxxxxxxxxxx" <nvdimm@xxxxxxxxxxxxxxx>, "linux-nvme@xxxxxxxxxxxxxxxxxxx" <linux-nvme@xxxxxxxxxxxxxxxxxxx>, "linux-scsi@xxxxxxxxxxxxxxx" <linux-scsi@xxxxxxxxxxxxxxx>
In-reply-to: <20240605063031.3286655-8-hch@lst.de>
References: <20240605063031.3286655-1-hch@lst.de> <20240605063031.3286655-8-hch@lst.de>
User-agent: Mozilla Thunderbird

On 6/4/2024 11:28 PM, Christoph Hellwig wrote:
> Use the text to integer helper that has error handling and doesn't modify
> the input pointer.
> 
> Signed-off-by: Christoph Hellwig<hch@xxxxxx>

Looks good.

Reviewed-by: Chaitanya Kulkarni <kch@xxxxxxxxxx>

-ck

References:
- move integrity settings to queue_limits
  - From: Christoph Hellwig
- [PATCH 07/12] block: use kstrtoul in flag_store
  - From: Christoph Hellwig

Prev by Date: Re: [PATCH 06/12] block: factor out flag_{store,show} helper for integrity
Next by Date: Re: [PATCH 11/12] block: invert the BLK_INTEGRITY_{GENERATE,VERIFY} flags
Previous by thread: Re: [PATCH 07/12] block: use kstrtoul in flag_store
Next by thread: [PATCH 08/12] block: don't pretend to generate/verify for non-PI metadata
Index(es):
- Date
- Thread

[Index of Archives] [Linux RAID] [Linux SCSI] [Linux ATA RAID] [IDE] [Linux Wireless] [Linux Kernel] [ATH6KL] [Linux Bluetooth] [Linux Netdev] [Kernel Newbies] [Security] [Git] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Device Mapper]