On Mon, Jun 03, 2024 at 01:47:17PM -0600, Keith Busch wrote:
> On Mon, Jun 03, 2024 at 09:26:45PM +0200, Andreas Hindborg wrote:
> > - dev->blocksize = round_down(dev->blocksize, 512);
> > - dev->blocksize = clamp_t(unsigned int, dev->blocksize, 512, 4096);
> > + if (blk_validate_block_size(dev->blocksize) != 0) {
> > + return -EINVAL;
> > + }
>
> No need for the { } brackets for a one-line if.
or the != 0.
>
> It also looks like a good idea if this check was just done in
> blk_validate_limits() so that each driver doesn't have to do their own
> checks. That block function is kind of recent though.
Yes. We already discussed this in another thread a few days ago.
