Re: [PATCH] null_blk: fix validation of block size

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Andreas Hindborg <nmi@xxxxxxxxxxxx>, Jens Axboe <axboe@xxxxxxxxx>
Subject: Re: [PATCH] null_blk: fix validation of block size
From: Bart Van Assche <bvanassche@xxxxxxx>
Date: Mon, 3 Jun 2024 10:02:03 -0700
Cc: Andreas Hindborg <a.hindborg@xxxxxxxxxxx>, Keith Busch <kbusch@xxxxxxxxxx>, linux-block@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
In-reply-to: <20240601202351.691952-1-nmi@metaspace.dk>
References: <20240601202351.691952-1-nmi@metaspace.dk>
User-agent: Mozilla Thunderbird

On 6/1/24 13:23, Andreas Hindborg wrote:

+	    ((dev->blocksize & (dev->blocksize - 1)) != 0)) {


Please use is_power_of_2() instead of open-coding it.

Bart.

References:
- [PATCH] null_blk: fix validation of block size
  - From: Andreas Hindborg

Prev by Date: Re: [PATCH] null_blk: fix validation of block size
Next by Date: Re: [PATCH v20 02/12] Add infrastructure for copy offload in block and request layer.
Previous by thread: Re: [PATCH] null_blk: fix validation of block size
Next by thread: [syzbot] [block?] WARNING in mempool_init_node
Index(es):
- Date
- Thread

[Index of Archives] [Linux RAID] [Linux SCSI] [Linux ATA RAID] [IDE] [Linux Wireless] [Linux Kernel] [ATH6KL] [Linux Bluetooth] [Linux Netdev] [Kernel Newbies] [Security] [Git] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Device Mapper]

Powered by Linux