Re: [PATCH 07/12] sd: factor out a sd_discard_mode helper

To: Christoph Hellwig <hch@xxxxxx>, Jens Axboe <axboe@xxxxxxxxx>, "Martin K. Petersen" <martin.petersen@xxxxxxxxxx>
Subject: Re: [PATCH 07/12] sd: factor out a sd_discard_mode helper
From: Bart Van Assche <bvanassche@xxxxxxx>
Date: Wed, 29 May 2024 14:11:28 -0700
Cc: Richard Weinberger <richard@xxxxxx>, Anton Ivanov <anton.ivanov@xxxxxxxxxxxxxxxxxx>, Johannes Berg <johannes@xxxxxxxxxxxxxxxx>, Josef Bacik <josef@xxxxxxxxxxxxxx>, Ilya Dryomov <idryomov@xxxxxxxxx>, Dongsheng Yang <dongsheng.yang@xxxxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, linux-um@xxxxxxxxxxxxxxxxxxx, linux-block@xxxxxxxxxxxxxxx, nbd@xxxxxxxxxxxxxxxx, ceph-devel@xxxxxxxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx, linux-scsi@xxxxxxxxxxxxxxx
In-reply-to: <20240529050507.1392041-8-hch@lst.de>
References: <20240529050507.1392041-1-hch@lst.de> <20240529050507.1392041-8-hch@lst.de>
User-agent: Mozilla Thunderbird

On 5/28/24 22:04, Christoph Hellwig wrote:

Split the logic to pick the right discard mode into a little helper
to prepare for further changes.


Reviewed-by: Bart Van Assche <bvanassche@xxxxxxx>

References:
- convert the SCSI ULDs to the atomic queue limits API
  - From: Christoph Hellwig
- [PATCH 07/12] sd: factor out a sd_discard_mode helper
  - From: Christoph Hellwig