On Mon, May 27, 2024 at 11:39:47PM +0100, Matthew Wilcox wrote: > > > + AS_FOLIO_ORDER_MIN = 16, > > > + AS_FOLIO_ORDER_MAX = 21, /* Bits 16-25 are used for FOLIO_ORDER */ > > > }; > > > > > > +#define AS_FOLIO_ORDER_MIN_MASK 0x001f0000 > > > +#define AS_FOLIO_ORDER_MAX_MASK 0x03e00000 > > > > As you changed the mapping flag offset, these masks also needs to be > > changed accordingly. > > That's why I did change them? How about: -#define AS_FOLIO_ORDER_MIN_MASK 0x001f0000 -#define AS_FOLIO_ORDER_MAX_MASK 0x03e00000 +#define AS_FOLIO_ORDER_MIN_MASK (31 << AS_FOLIO_ORDER_MIN) +#define AS_FOLIO_ORDER_MAX_MASK (31 << AS_FOLIO_ORDER_MAX)
