On 5/24/24 09:39, Christoph Hellwig wrote:
On Fri, May 24, 2024 at 08:21:19AM +0200, Hannes Reinecke wrote:
blk_validate_zoned_limits() checks whether any of the zoned limits
are set for non-zoned limits. As blk_set_stacking_limits() sets
max_zone_append_sectors() it'll fail to validate.
Except that you now broke it for zone devices. Normally if we are
not building a stacked zoned device there should at least be one
underlying device that has a zero max_zone_append_limit, thus lowering
the stacked device limit to 0. I guess you have a scenario where that
is not the case, so please explain it so that we can fix it.
I just found it weird that a simple 'memset' for the initial device
configuration and then calling blk_set_stacking_limits() will lead to a
failure in blk_validate_limits() ...
But I'll relent; this had been coming up during large block testing with
NVMe, but was only tangentially related.
So I'll retract it.
Cheers,
Hannes