On Thu, May 23, 2024 at 11:48:50AM -0400, Mike Snitzer wrote: > > Reality is, we have stacking block devices that regularly are _not_ > accounted for when people make changes to block core queue_limits > code. That is a serious problem. Well, maybe we need to sure blktests covers this instead of either impossible to run on a stock distro (device_mapper tests) or always somehow hanging (lvm2 testsuite) separate tests.. > Happy to see the need for the 'stacking' flag to go away in time but I > fail to see why it is "fundamentally wrong". Because stacking limits should not in any way be built different. Both the stacking flag and your restoring of the value just hack around the problem instead of trying to address it. Let's use a little time to sort this out properly instead of piling up hacks.