On Sun, May 12, 2024 at 12:30:40AM +0100, Matthew Wilcox wrote: > On Sat, May 11, 2024 at 04:09:48PM -0700, Luis Chamberlain wrote: > > We can't just do this, we need to consider the actual nvme cap (test it, > > and if it crashes and below what the page cache supports, then we have > > to go below) and so to make the enablment easier. So we could just move > > this to helper [0]. Then when the bdev cache patch goes through the > > check for CONFIG_BUFFER_HEAD can be removed, if this goes first. > > > > We crash if we go above 1 MiB today, we should be able to go up to 2 > > MiB but that requires some review to see what stupid thing is getting > > in the way. > > > > [0] https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux.git/commit/?h=20240408-lbs-scsi-kludge&id=1f7f4dce548cc11872e977939a872b107c68ad53 > > This is overengineered garbage. What's the crash? I had only tested it with iomap, I had not tested it with buffer-heads, and so it would require re-testing. It's Saturday 5pm, I should be doing something else other than being on my computer. Luis
