On 09/05/2024 15:00, Jens Axboe wrote:
But, uggh, now I see more C=1 warnings on Jens' 6.9 branch. It's quite
late to be sending fixes for those (for 6.9)...
I'll send then anyway.
Send it for 6.10.
ok, fine.
JFYI, Here's what I found on the 6.10 queue in block/:
block/bdev.c:377:17: warning: symbol 'blockdev_mnt' was not declared.
Should it be static?
block/blk-settings.c:263:9: warning: context imbalance in
'queue_limits_commit_update' - wrong count at exit
block/blk-cgroup.c:811:5: warning: context imbalance in
'blkg_conf_prep' - wrong count at exit
block/blk-cgroup.c:941:9: warning: context imbalance in
'blkg_conf_exit' - different lock contexts for basic block
block/blk-iocost.c:732:9: warning: context imbalance in 'iocg_lock' -
wrong count at exit
block/blk-iocost.c:743:28: warning: context imbalance in 'iocg_unlock'
- unexpected unlock
block/blk-zoned.c:576:30: warning: context imbalance in
'disk_get_and_lock_zone_wplug' - wrong count at exit
block/blk-zoned.c: note: in included file (through include/linux/blkdev.h):
./include/linux/bio.h:592:9: warning: context imbalance in
'blk_zone_wplug_handle_write' - unexpected unlock
block/blk-zoned.c:1721:31: warning: context imbalance in
'blk_revalidate_seq_zone' - unexpected unlock
block/bfq-iosched.c:5498:9: warning: context imbalance in
'bfq_exit_icq' - different lock contexts for basic block
Actually most pre-date v6.9 anyway, apart from the zoned stuff. And the
bdev.c static warning is an outstanding patch, which I replied to.
At a glance, some of those pre-v6.9 issues looks non-trivial to fix,
which may be the reason that they have not been fixed...
John
