On Mon, Apr 29, 2024 at 05:11:25PM +0200, David Sterba wrote: > > - if (ret) { > > - fput(*bdev_file); > > - goto error; > > + if (holder) { > > + ret = set_blocksize(bdev, BTRFS_BDEV_BLOCKSIZE); > > The subject mentions a different function, you're removing it from > btrfs_get_bdev_and_sb() not btrfs_get_dev_args_from_path(). ... conditional upon holder being NULL, which happens only when called by btrfs_get_dev_args_from_path().