Re: [PATCH 1/1] null_blk: Fix the WARNING: modpost: missing MODULE_DESCRIPTION()

Zhu Yanjun <yanjun.zhu@xxxxxxxxx> · Mon, 29 Apr 2024 21:48:28 +0200

在 2024/4/29 21:45, Chaitanya Kulkarni 写道:
On 4/29/24 02:12, Zhu Yanjun wrote:
No functional changes intended.

Fixes: f2298c0403b0 ("null_blk: multi queue aware block test driver")
Signed-off-by: Zhu Yanjun <yanjun.zhu@xxxxxxxxx>
---
   drivers/block/null_blk/main.c | 1 +
   1 file changed, 1 insertion(+)

diff --git a/drivers/block/null_blk/main.c b/drivers/block/null_blk/main.c
index eed63f95e89d..aa084ae75e53 100644
--- a/drivers/block/null_blk/main.c
+++ b/drivers/block/null_blk/main.c
@@ -2121,4 +2121,5 @@ module_init(null_init);
   module_exit(null_exit);
   
   MODULE_AUTHOR("Jens Axboe <axboe@xxxxxxxxx>");
+MODULE_DESCRIPTION("Null test block driver");
why not :-

"multi queue aware block test driver"

Thanks a lot. The above is from Kconfig.

Your suggestion is more fascinating. If everyone agrees, I will use yours.


   MODULE_LICENSE("GPL");
irrespective of that, looks good.

Reviewed-by: Chaitanya Kulkarni <kch@xxxxxxxxxx>

Thanks

Zhu Yanjun


-ck


--
I only represent myself.
Zhu Yanjun or Yanjun.Zhu








