On Sat, Apr 27, 2024 at 09:02:14AM +0200, Christoph Hellwig wrote: > On Fri, Apr 26, 2024 at 12:09:34AM +0530, Kanchan Joshi wrote: > > From: Anuj Gupta <anuj20.g@xxxxxxxxxxx> > > > > Set the bip_vcnt correctly in bio_integrity_init_user and > > bio_integrity_copy_user. If the bio gets split at a later point, > > this value is required to set the right bip_vcnt in the cloned bio. > > > > Signed-off-by: Anuj Gupta <anuj20.g@xxxxxxxxxxx> > > Signed-off-by: Kanchan Joshi <joshi.k@xxxxxxxxxxx> > > Looks good: > > Reviewed-by: Christoph Hellwig <hch@xxxxxx> > > Please add a Fixes tag and submit it separately from the features. > > I'm actually kinda surprised the direct user mapping of integrity data > survived so far without this. The only existing use case for user metadata is REQ_OP_DRV_IN/OUT, which never splits, so these initial fixes only really matter after this series adds new usage for generic READ/WRITE.