On 4/26/24 8:02 AM, Matthew Wilcox wrote: > On Fri, Apr 26, 2024 at 07:41:29AM -0600, Jens Axboe wrote: >> On 4/25/24 10:37 AM, Matthew Wilcox (Oracle) wrote: >>> Several modules use __bio_add_page() today and may need to be converted >>> to bio_add_folio_nofail(). >> >> Confused, we don't have any modular users of this. A change like this >> should be submitted with a conversion. > > Thank you for reinforcing my point. > > https://lore.kernel.org/linux-fsdevel/ZiqHIH3lIzcRXCkU@xxxxxxxxxxxxxxxxxxxx/ > > Can I have an Acked-by so David can take it through the btrfs tree? Yeah that's fine, makes more sense now than the standalone one: Reviewed-by: Jens Axboe <axboe@xxxxxxxxx> -- Jens Axboe