On Wed, Apr 24, 2024 at 06:52:46PM +0530, Kundan Kumar wrote: > > while the same_page logic in bio_iov_add_zone_append_page probablyg > > needs to be folio-ized first, it should be handled the same way here > > as well. > > Regarding the same_page logic, if we add same page twice then we release > the page on second addition. It seemed to me that this logic will work even > if we merge large order folios. Please let me know if I am missing something. The 'same_page' logic should only happen with successive calls to __bio_iov_iter_get_pages(), and only for the first page considered, so I think the logic is handled the same with your change.