On Apr 18, 2024 / 07:18, Chaitanya Kulkarni wrote: > On 4/17/24 23:36, Daniel Wagner wrote: > > On Thu, Apr 18, 2024 at 06:12:40AM +0000, Chaitanya Kulkarni wrote: > >> agree they should be uppercase not denying that, the only reason I > >> asked since existing variables are lowercase, it'd be very confusing > >> to have some variables in nvme category with lower case and some > >> upper case ... > > Same here, so let's fix this and add upper case versions of the existing > > variables incl documentation. I suggest we keep the lower case ones > > around for awhile (maybe incl a warning?) before we drop the support. > > > > What do you think? > > that should work but let's be very careful about removing lowercase > options since it might break bunch of setups .... I agree with this approach. I've just sent out v3 to which I added the patches to introduce the uppercase options below: nvme_img_size -> NVME_IMG_SIZE nvme_num_iter -> NVME_NUM_ITER use_rxe -> USE_RXE Both uppercase and lowercase options will work, but it is guided to use the uppercase option.
