Re: [PATCH v2 1/2] block: prevent freeing a zone write plug too early

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Damien Le Moal <dlemoal@xxxxxxxxxx>
Subject: Re: [PATCH v2 1/2] block: prevent freeing a zone write plug too early
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Sun, 21 Apr 2024 23:23:57 -0700
Cc: Jens Axboe <axboe@xxxxxxxxx>, linux-block@xxxxxxxxxxxxxxx
In-reply-to: <20240420075811.1276893-2-dlemoal@kernel.org>
References: <20240420075811.1276893-1-dlemoal@kernel.org> <20240420075811.1276893-2-dlemoal@kernel.org>

On Sat, Apr 20, 2024 at 04:58:10PM +0900, Damien Le Moal wrote:
> Avoid this by calling flush_work() from disk_free_zone_wplug_rcu().

Calling flush_work from a rcu callback is just asking for nasty
deadlocks.

What prevents you from just holding an extra zwplug reference while
blk_zone_wplug_bio_work is running?

Follow-Ups:
- Re: [PATCH v2 1/2] block: prevent freeing a zone write plug too early
  - From: Damien Le Moal

References:
- [PATCH v2 0/2] Fixes for zone write plugging
  - From: Damien Le Moal
- [PATCH v2 1/2] block: prevent freeing a zone write plug too early
  - From: Damien Le Moal

Prev by Date: [PATCH v2] block: Add ioprio to block_rq tracepoint
Next by Date: Re: [PATCH v2 2/2] block: use a per disk workqueue for zone write plugging
Previous by thread: [PATCH v2 1/2] block: prevent freeing a zone write plug too early
Next by thread: Re: [PATCH v2 1/2] block: prevent freeing a zone write plug too early
Index(es):
- Date
- Thread

[Index of Archives] [Linux RAID] [Linux SCSI] [Linux ATA RAID] [IDE] [Linux Wireless] [Linux Kernel] [ATH6KL] [Linux Bluetooth] [Linux Netdev] [Kernel Newbies] [Security] [Git] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Device Mapper]

Powered by Linux