On Apr 19, 2024 / 16:01, Yu Kuai wrote:
> Hi,
>
> 在 2024/04/19 12:29, Shinichiro Kawasaki 写道:
> > On Apr 17, 2024 / 10:20, Yu Kuai wrote:
> > > From: Yu Kuai <yukuai3@xxxxxxxxxx>
...
> > > +group_requires() {
> > > + _have_root
> > > + _have_null_blk
> > > + _have_kernel_option BLK_DEV_THROTTLING
> > > + _have_cgroup2_controller io
> >
> > This rc file introduces the dependency to the bc command. I suggest to check the
> > requirement by adding one more check here:
> >
> > _have_proggram bc
>
> Ok, and perhaps also check dd as well?
Not really, because README describes that blktests depends on GNU coreutils
which includes dd. There are many other test cases which use dd without
checking dd, then it will be odd to check it only for the throtl group.
