On 4/17/24 19:10, Shinichiro Kawasaki wrote:
> On Apr 17, 2024 / 16:47, Christoph Hellwig wrote:
>> Commit 4601b4b130de ("block: reopen the device in blkdev_reread_part")
>> lost the propagation of I/O errors from the low-level read of the
>> partition table to the user space caller of the BLKRRPART.
>>
>> Apparently some user space relies on, so restore the propagation. This
>> isn't exactly pretty as other block device open calls explicitly do not
>> are about these errors, so add a new BLK_OPEN_STRICT_SCAN to opt into
>> the error propagation.
>>
>> Fixes: 4601b4b130de ("block: reopen the device in blkdev_reread_part")
>> Reported-by: Saranya Muruganandam <saranyamohan@xxxxxxxxxx>
>> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
>> ---
>>
>> Changes since v1:
>> - fix the rebase error that causes the flag to reuse a bit number
>> - fixed a comment typo
> Thanks. The v2 patch looks good to me. I also confirmed that the corresponding
> blktests test case block/036 passes with this patch.
>
> Reviewed-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@xxxxxxx>
> Tested-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@xxxxxxx>
seems like my reviewed-by tag from V1 is missing ...
here you go again
Reviewed-by: Chaitanya Kulkarni <kch@xxxxxxxxxx>
-ck
