On Tue, Apr 16, 2024 at 07:32:53AM +0100, Al Viro wrote: > kernel/power/swap.c:371: res = set_blocksize(file_bdev(hib_resume_bdev_file), PAGE_SIZE); > kernel/power/swap.c:1577: set_blocksize(file_bdev(hib_resume_bdev_file), PAGE_SIZE); > Special cases (for obvious reasons); said that, why do we bother > with set_blocksize() on those anyway? AFAICS, we really don't need either - all IO is done via hib_submit_io(), which sets a single-page bio and feeds it to submit_bio{,_wait}() directly. We are *not* using the page cache of the block device in question, let alone any buffer_head instances. Could swsusp folks comment?