Re: [PATCH 09/11] dm-vdo: use bdev_nr_bytes(bdev) instead of i_size_read(bdev->bd_inode)

To: Al Viro <viro@xxxxxxxxxxxxxxxxxx>, Christian Brauner <brauner@xxxxxxxxxx>
Subject: Re: [PATCH 09/11] dm-vdo: use bdev_nr_bytes(bdev) instead of i_size_read(bdev->bd_inode)
From: Matthew Sakai <msakai@xxxxxxxxxx>
Date: Thu, 11 Apr 2024 14:04:37 -0400
Cc: Jan Kara <jack@xxxxxxx>, Yu Kuai <yukuai1@xxxxxxxxxxxxxxx>, hch@xxxxxx, axboe@xxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, linux-block@xxxxxxxxxxxxxxx, yi.zhang@xxxxxxxxxx, yangerkun@xxxxxxxxxx, "yukuai (C)" <yukuai3@xxxxxxxxxx>
In-reply-to: <20240411145346.2516848-9-viro@zeniv.linux.org.uk>
References: <20240411144930.GI2118490@ZenIV> <20240411145346.2516848-1-viro@zeniv.linux.org.uk> <20240411145346.2516848-9-viro@zeniv.linux.org.uk>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0

On 4/11/24 10:53, Al Viro wrote:

going to be faster, actually - shift is cheaper than dereference...

Signed-off-by: Al Viro <viro@xxxxxxxxxxxxxxxxxx>


Reviewed-by: Matthew Sakai <msakai@xxxxxxxxxx>

References:
- Re: [PATCH vfs.all 22/26] block: stash a bdev_file to read/write raw blcok_device
  - From: Al Viro
- [PATCH 01/11] block_device: add a pointer to struct address_space (page cache of bdev)
  - From: Al Viro
- [PATCH 09/11] dm-vdo: use bdev_nr_bytes(bdev) instead of i_size_read(bdev->bd_inode)
  - From: Al Viro