On Wed 12-04-17 01:17:46, Christoph Hellwig wrote: > On Wed, Mar 29, 2017 at 12:56:17PM +0200, Jan Kara wrote: > > Similarly to set_bdev_super() NILFS2 just used block device reference to > > bdi. Convert it to properly getting bdi reference. The reference will > > get automatically dropped on superblock destruction. > > I really wish we could get rid of this open coding in block based > file systems.. Well, nilfs has it because it has its own ->mount implementation (and similarly gfs2). If someone has idea how common code out of those could be factored out, bdi handling could be part of that... > Otherwise looks fine: > > Reviewed-by: Christoph Hellwig <hch@xxxxxx> Thanks. Honza -- Jan Kara <jack@xxxxxxxx> SUSE Labs, CR