On Apr 04, 2024 / 10:29, Daniel Wagner wrote: > On Thu, Apr 04, 2024 at 07:43:28AM +0000, Shinichiro Kawasaki wrote: ... > > It sounds an interesting idea :) I prototyped the common code change based on > > the idea and shared it on GitHub [*]. It introduces two new config arrays > > NVMET_BLKDEV_TYPES and NVMET_TR_TYPES. When these two are set in config file as > > follows, > > > > NVMET_BLKDEV_TYPES=(device file) > > NVMET_TR_TYPES=(loop rdma tcp) > > > > it will run a single test case as follows. 2 x 3 = 6 times repeptitions. > > > > $ sudo ./check nvme/006 > > nvme/006(nvmet dev=device tr=loop)(create an NVMeOF target) [passed] > > runtime 0.090s ... 0.091s > > nvme/006(nvmet dev=device tr=rdma)(create an NVMeOF target) [passed] > > runtime 0.310s ... 0.305s > > nvme/006(nvmet dev=device tr=tcp)(create an NVMeOF target) [passed] > > runtime 0.149s ... 0.153s > > nvme/006(nvmet dev=file tr=loop)(create an NVMeOF target) [passed] > > runtime 0.138s ... 0.135s > > nvme/006(nvmet dev=file tr=rdma)(create an NVMeOF target) [passed] > > runtime 0.300s ... 0.305s > > nvme/006(nvmet dev=file tr=tcp)(create an NVMeOF target) [passed] > > runtime 0.141s ... 0.147s > > > > I hope this meets your needs. > > Yes, this is very useful. > > > [*] https://github.com/kawasaki/blktests/tree/conditions > > I quickly looked into the changes. The only thing I'd say it looks a > bit hard to extend if we have yet another variable. But maybe I'd make > it too complex. I don't think we have to be too future proof here, > because we can change this part without problems, it is all 'under the > hood' and doesn't change the 'user interface'. > > Great stuff! Okay, thanks for the positive comment. I will brush up the patches and post for review. Let me have several days.
