Shinichiro/Daniel, On 4/3/24 02:00, Daniel Wagner wrote: > Hi Shinichiro, > > On Wed, Apr 03, 2024 at 04:54:28AM +0000, Shinichiro Kawasaki wrote: >> On the other hand, I see that the series has a couple of drawbacks: >> >> 1) When blktests users run with the default knob only, the test coverage will be >> smaller. To keep the current test coverage, the users need to run the check >> script twice: nvmet_blkdev_type=file and nvmet_blkdev_type=device. Some users >> may not do it and lose the test coverage. And some users, e.g., CKI project, >> need to adjust their script for this change. reducing code is always encouraged, but please don't change the test coverage and make user add additional steps to run the tests, IOW ./check nvme should run all the tests case by default as it dose today, this will keep your changes backward compatible .. I believe that is not too hard to achieve ? -ck
