On Mar 26, 2024 / 14:13, Daniel Wagner wrote:
> Remove the last positional argument for
> _nvme_passthrue_target_{setup|cleanup} which most test pass in the
> default subsysnqn anyway. There is little point in cluttering all the
> test textual noise.
>
> While at it, also use subsysnqn as variable name everywhere, instead of
> subsys_name.
...
> diff --git a/tests/nvme/037 b/tests/nvme/037
> index 159d9d990bb7..2fe37a7a7340 100755
> --- a/tests/nvme/037
> +++ b/tests/nvme/037
> @@ -22,12 +22,13 @@ test_device() {
> local ctrldev
>
> for ((i = 0; i < iterations; i++)); do
> - _nvmet_passthru_target_setup "${subsys}${i}"
> + _nvmet_passthru_target_setup --subsysnqn "${subsys}${i}"
> nsdev=$(_nvmet_passthru_target_connect "${subsys}${i}")
>
> _nvme_disconnect_subsys \
> --subsysnqn "${subsys}${i}" >>"${FULL}" 2>&1
> - _nvmet_passthru_target_cleanup "${subsys}${i}"
> + _nvme_disconnect_subsys "${subsys}${i}" >>"${FULL}" 2>&1
I believe that the line above is unnecessary. I took the liberty to remove it
when I applied this patch.
