On 3/28/24 15:51, Christoph Hellwig wrote: > On Thu, Mar 28, 2024 at 03:43:02PM +0900, Damien Le Moal wrote: >> That is indeed not great, but irrelevant for zone writes as the regular BIO plug >> is after the zone write plugging. So the regular BIO plug can only see at most >> one write request per zone. Even if that order changes, that will not result in >> unaligned write errors like before. But the reordering may still be bad for >> performance though, especially on HDD, so yes, we should definitely look into this. > > Irrelevant is not how I would frame it. Yes, it will not affect > correctness. But it will affect performance not just for the write > itself, but also in the long run as it affects the on-disk extent > layout. Agreed. -- Damien Le Moal Western Digital Research