Re: [PATCH] blk-throttle: Fix W=1 build issue in tg_prfill_limit()

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH] blk-throttle: Fix W=1 build issue in tg_prfill_limit()
From: John Garry <john.g.garry@xxxxxxxxxx>
Date: Tue, 26 Mar 2024 14:57:19 +0000
Cc: tj@xxxxxxxxxx, axboe@xxxxxxxxx, josef@xxxxxxxxxxxxxx, shli@xxxxxx, linux-block@xxxxxxxxxxxxxxx, cgroups@xxxxxxxxxxxxxxx
In-reply-to: <ZgLgedPipnZuyHCA@infradead.org>
Organization: Oracle Corporation
References: <20240325121905.2869271-1-john.g.garry@oracle.com> <ZgJzNvN4nQqKnhk5@infradead.org> <a4d8b56e-1814-4834-9d25-ef61ff6f1248@oracle.com> <ZgLgedPipnZuyHCA@infradead.org>
User-agent: Mozilla Thunderbird

On 26/03/2024 14:49, Christoph Hellwig wrote:

Here's how the current code could look (using only seq_printf):

That looks much better, thanks.

ok, I'll put it in a formal patch. It would be nice to put purely a"fix" for stable, but no one else has complained about this old warningAFAIK.


Thanks,
John

References:
- [PATCH] blk-throttle: Fix W=1 build issue in tg_prfill_limit()
  - From: John Garry
- Re: [PATCH] blk-throttle: Fix W=1 build issue in tg_prfill_limit()
  - From: Christoph Hellwig
- Re: [PATCH] blk-throttle: Fix W=1 build issue in tg_prfill_limit()
  - From: John Garry
- Re: [PATCH] blk-throttle: Fix W=1 build issue in tg_prfill_limit()
  - From: Christoph Hellwig