On Mar 22, 2024 / 14:50, Daniel Wagner wrote: > Remove the last positional argument for _nvme_connect_subsys which most It would be a bit better to mention _nvme_disconnect_subsys also. > test pass in the default subsysnqn anyway. There is little point in > cluttering all the test textual noise. > > Signed-off-by: Daniel Wagner <dwagner@xxxxxxx> I did a trial run with the series, and found that the test cases from nvme/033 to nvme/037 fail. The failure causes looks these two: 1) _nvmet_passthru_target_connect() still misses the change for the --subsysnqn option 2) _nvmet_disconnect_subsys() calls in the test cases missed changes for --subsysnqn option Could you recheck the test cases?
