On Mon, Mar 25, 2024 at 11:03:25AM +0800, Ming Lei wrote: > Also only q->limits.logical_block_size is fetched for small BS IO > fast path, I think log(lbs) can be cached in request_queue for avoiding the > extra fetch of q.limits. Especially, it could be easier to do so > with your recent queue limit atomic update changes. So. One thing I've been thinking of for a while (and which Bart also mentioned) is tht queue_limits currently is a bit of a mess between the actual queue limits, and the gneidks configuration. The logical block size is firmly in the latter, and we should probably move it to the gendisk eventually. Depending on how converting the SCSI ULDs to the atomic queue limits API goes that imght happen rather sooner than later.
