On Fri, Mar 22, 2024 at 09:35:05AM +0000, Shinichiro Kawasaki wrote:
> --- a/tests/nvme/010
> > +++ b/tests/nvme/010
> > @@ -20,17 +20,16 @@ test() {
> >
> > _setup_nvmet
> >
> > - local nvmedev
> > + local ns
> >
> > _nvmet_target_setup
> >
> > _nvme_connect_subsys
> >
> > - nvmedev=$(_find_nvme_dev "${def_subsysnqn}")
> > - _check_uuid "${nvmedev}"
> > + ns=$(_find_nvme_ns "${def_subsys_uuid}")
>
> Currently, _check_uuid() compares the uuid with wwid. On the other hand, the
> modified _find_nvme_ns() does not refer wwid. This looks a relax of test
> condition. Do you think this relax is fine?
We still have the _check_uuid in nvme/008 and nvme/009, so while drop
this part here it is still tested. I think we should try to make the
tests as slim as possible, which includes the removal duplicate tests
snippets. I think it is important to keep an eye on the runtime of each
test.
