On 04/10/2017 11:36 AM, Javier González wrote: > Changes since v3: > * Apply Bart's feedback [1] Thanks for having addressed these comments. But please also make sure that the pblk driver builds cleanly with W=1 C=2. When running "make M=drivers/lightnvm W=1 C=2" several warnings are reported that should be reviewed. At least the endianness warnings should be addressed. An example: CHECK drivers/lightnvm/pblk-gc.c drivers/lightnvm/pblk-gc.c:254:18: warning: incorrect type in assignment (different base types) drivers/lightnvm/pblk-gc.c:254:18: expected unsigned long long [usertype] *lba_list drivers/lightnvm/pblk-gc.c:254:18: got restricted __le64 [usertype] * Please also review the warnings reported by smatch (make M=drivers/lightnvm C=2 CHECK="smatch -p=kernel"). A few examples that most likely indicate bugs: CHECK drivers/lightnvm/pblk-init.c drivers/lightnvm/pblk-init.c:915: pblk_init() error: passing non negative 1 to ERR_PTR drivers/lightnvm/pblk-rb.c:782: pblk_rb_tear_down_check() error: we previously assumed 'rb->entries' could be null (see line 778) CHECK drivers/lightnvm/pblk-read.c drivers/lightnvm/pblk-read.c:486: pblk_submit_read_gc() error: 'bio' dereferencing possible ERR_PTR() Thanks, Bart.
