On Mon, 2017-04-10 at 13:00 -0700, Omar Sandoval wrote: > Can you just move blk_queue_flags_fops to blk_mq_debugfs_queue_attrs > instead of adding blk_queue_attrs? Hello Omar, Are you aware that that change will move the "state" attribute one level down in the hierarchy? blk_mq_debugfs_queue_attrs attributes are created under "mq" while blk_queue_flags_fops attributes are created at the same level as the "mq" attribute. I had added blk_queue_flags_fops because the "state" attribute is not related to blk-mq. That attribute is also relevant for single-queue block layer queues. Bart.
