On Fri, Mar 15, 2024 at 12:27:31PM -0600, Keith Busch wrote: > On Fri, Mar 15, 2024 at 12:23:23PM -0600, Keith Busch wrote: > > This looks good. Unnecessary suggestion, but since you're already > > changing these, might as well replace "sector" with "idx" here and skip > > the duplicated shift in brd_lookup_page(). > > Sorry forget that, all the other existing callers just want the > sector_t. Yeah, but I could just inline the xa_load(). Doesn't really seem like a big deal to me, so I left it for now. Got to leave something for other people to do ;-)