On Thu, Mar 14, 2024 at 9:58 AM Andreas Hindborg <nmi@xxxxxxxxxxxx> wrote: > > Yes, good point. Another option suggested by Miguel is that > `__blk_mq_free_request` need not be exported at all. We can make it > non-static and then call it from > `rust_helper_blk_mq_free_request_internal()`. Then only the latter will > be in the kernel image symbol table, which might be better in terms of > not exposing `__blk_mq_free_request()` directly. The helper is not needed, i.e. what I meant was to make it non-static and add it to `include/linux/blk-mq.h`. Cheers, Miguel