On Wed, Mar 13, 2024 at 07:16:23PM -0700, Christoph Hellwig wrote: > This reverts commit 8a08c5fd89b447a7de7eb293a7a274c46b932ba2. > > It turns out while this is a perfectly valid and long overdue thing to do > for user initiated discards / zeroing from the ioctl handler, it actually > breaks file system use of the discard helper by interrupting in places > the file system doesn't expect, and by leaving the bio chain in a state > that the file system callers of (at least) __blkdev_issue_discard do > not expect. > > Revert the change for now, we'll redo it for the next merge window > after refactoring the code to better split the file system vs ioctl > callers and cleaning up a few other loose ends. > > Reported-by: Chandan Babu R <chandanbabu@xxxxxxxxxx> > Signed-off-by: Christoph Hellwig <hch@xxxxxx> Acked-by: Keith Busch <kbusch@xxxxxxxxxx>
