On Tue, Mar 05, 2024 at 09:38:41AM +0000, Shinichiro Kawasaki wrote: > On Mar 04, 2024 / 17:13, Daniel Wagner wrote: > > The re-authentication is a soft state, meaning unless the host has to > > reconnect a key change on the target side is not observed. Extend the > > current test with a forced reconnect after a key change. This > > exercises the DNR handling code of the host. > > > > Signed-off-by: Daniel Wagner <dwagner@xxxxxxx> > > This looks a good improvement of the test case. I have two comments: > > - The commit title says nvme/048, but it should be nvme/045. Indeed :) > - The helper functions nvmf_wait_for_state() and set_nvmet_attr_qid_max() > are exactly same as those in nvme/048, aren't they? > Probably, it's the better to move them to nvme/rc, as a preparation patch. I forgot that we already had those two helpers. Sure, will do.
