On Thu, 29 Feb 2024 06:38:44 -0800, Christoph Hellwig wrote: > nbd_config_put currently clears discard_sectors when unusing a device. > This is pretty odd behavior and different from the sector size > configuration which is simply left in places and then reconfigured when > nbd_set_size is as part of configuring the device. Change nbd_set_size > to clear discard_sectors if discard is not supported so that all the > queue limits changes are handled in one place. > > [...] Applied, thanks! [1/3] nbd: don't clear discard_sectors in nbd_config_put commit: 7ea201f2cc1da999b9a0a23ea20b64eb2c4719a9 [2/3] nbd: freeze the queue for queue limits updates commit: 242a49e5c8784e93a99e4dc4277b28a8ba85eac5 [3/3] nbd: use the atomic queue limits API in nbd_set_size commit: 268283244c0f018dec8bf4a9c69ce50684561f46 Best regards, -- Jens Axboe