Re: [PATCH v3 2/5] blk-mq: Restart a single queue if tag sets are shared

[Bart Van Assche <Bart.VanAssche@xxxxxxxxxxx>]

On Thu, 2017-04-06 at 13:21 -0600, Jens Axboe wrote:
> On 04/06/2017 01:12 PM, Jens Axboe wrote:
> > On 04/06/2017 12:10 PM, Bart Van Assche wrote:
> > > +		for (i = 0; i < queue->nr_hw_queues; i++) {
> > > +			j = (i + hctx->queue_num + 1) % queue->nr_hw_queues;
> > > +			h = queue->queue_hw_ctx[j];
> > > +			if (h->tags == tags && blk_mq_sched_restart_hctx(h))
> > > +				break;
> > 
> > I'm pretty sure that doing:
> > 
> > 	j = i + hctx->queue_num + 1;;
> 
> And 'i' too many there of course:
> 
>  	j = hctx->queue_num + 1;;

Hello Jens,

Thanks for the feedback. I will implement this change and retest this patch
series.

Bart.