On Wed, Feb 21, 2024 at 01:50:55PM +0800, Zhaoyang Huang wrote: > On Wed, Feb 21, 2024 at 1:41 PM Eric Biggers <ebiggers@xxxxxxxxxx> wrote: > > > > On Wed, Feb 21, 2024 at 01:26:24PM +0800, zhaoyang.huang wrote: > > > +/* > > > + * bio_set_active_ioprio_folio is helper function to count the bio's > > > + * content's activities which measured by MGLRU. > > > + * The file system should call this function after bio_add_page/folio for > > > + * the buffered read/write/sync. > > > + */ > > > +#ifdef CONFIG_BLK_CONT_ACT_BASED_IOPRIO > > > +void bio_set_active_ioprio_folio(struct bio *bio, struct folio *folio) > > > > How did you test this? Nothing calls this function, so this patch can't > > actually be doing anything. Are you planning to update any filesystems to use > > this? > Thanks for asking. I verified this patch in an Android based 6GB RAM > system by modifying EROFS/F2FS/EXT4's aops API which I didn't > upstreaming yet. I would like to recommend this to the desired fs if > this is accepted. This patch needs to come with a user. Unused code can't be accepted. - Eric
