On 2/19/24 12:06 AM, Shinichiro Kawasaki wrote:
On Feb 16, 2024 / 15:30, Alan Adamson wrote:
Tests the ability to enable and disable error logging for passthru admin commands issued to
the controller and passthru IO commands issued to a namespace.
Alan, thanks for the patch. Good to get the test coverage back.
I applied the patch and ran nvme/039 for a QEMU nvme device on the kernel
v6.8-rc5. Then I observed the failure below:
---------------------------------------------------------------------
nvme/039 => nvme0n1 (test error logging) [failed]
runtime 5.308s ... 5.318s
--- tests/nvme/039.out 2024-02-19 15:59:12.143488379 +0900
+++ /home/shin/Blktests/blktests/results/nvme0n1/nvme/039.out.bad 2024-02-19 16:33:06.135840798 +0900
@@ -3,5 +3,4 @@
Read(0x2) @ LBA 0, 1 blocks, Unknown (sct 0x3 / sc 0x75) DNR
Write(0x1) @ LBA 0, 1 blocks, Write Fault (sct 0x2 / sc 0x80) DNR
Identify(0x6), Access Denied (sct 0x2 / sc 0x86) DNR cdw10=0x1 cdw11=0x0 cdw12=0x0 cdw13=0x0 cdw14=0x0 cdw15=0x0
- Read(0x2), Invalid Command Opcode (sct 0x0 / sc 0x1) DNR cdw10=0x0 cdw11=0x0 cdw12=0x1 cdw13=0x0 cdw14=0x0 cdw15=0x0
Test complete
---------------------------------------------------------------------
Has to do with the nvme device having multiple namespaces. I'll fix the
test.
Thanks,
Alan