On Tue, Jan 23, 2024 at 02:26:45PM +0100, Christian Brauner wrote: > and move both of them to the private block header. There's no caller in > the tree anymore that uses them directly. the subject only takes about a single helper, but then the commit message mentions "both". Seems like the subject is missing a "bdev_open_by_dev and". Otherwise looks good: Reviewed-by: Christoph Hellwig <hch@xxxxxx>