On Sun, Jan 28, 2024 at 06:59:31PM -0800, Bart Van Assche wrote: >> + /* >> + * For read-ahead of large files to be effective, we need to read ahead >> + * at least twice the optimal I/O size. >> + */ >> + bdi->ra_pages = max(lim->io_opt * 2 / PAGE_SIZE, VM_READAHEAD_PAGES); >> + bdi->io_pages = lim->max_sectors >> (PAGE_SHIFT - 9); >> +} > > Would this be a good opportunity to change (PAGE_SHIFT - 9) into > PAGE_SECTORS_SHIFT? If I have to respin for some reason I'll include it. Otherwise feel free to send a trivial follow on patch.
