On Fri, Jan 26, 2024 at 08:05:21AM +0100, Hannes Reinecke wrote: > > BIOs that need splitting. Doing so also fixes issues with zoned devices > > as a large BIO may cross over a zone boundary, which breaks null_blk > > zone emulation. > > > That feels so wrong. Why would we need to apply queue limits to a bio? > (Yes, I know why. We still shouldn't be doing it.) Because a driver that has limits should enforce them. Your hardware doesn't suddenly use limits because you're using a bio based driver, and null_blk shouldn't suddenly ignore the configured limits just because you're using it in bio mode. The patch looks good: Reviewed-by: Christoph Hellwig <hch@xxxxxx> But yeah, I'd rather kill the bio mode. Jens, are you attached to the bio mode? Otherwise I'll cook up a patch over the weekend.
