On 1/24/24 2:29 AM, Christoph Hellwig wrote: > On Tue, Jan 23, 2024 at 10:30:37AM -0700, Jens Axboe wrote: >> We never use more than 64 max in here, we can change them from unsigned >> short to just a byte. Add a BUILD_BUG_ON() check, in case the max plug >> count changes in the future. > > Do we care about the size of this once per task structure? byte-level > access tends to be quite a bit more expensive on various architectures. I don't think we care that much, and honestly I'm fine dropping the last two patches. They don't matter that much to me, and we can always revisit if we do care more about shrinking the blk_plug later on. -- Jens Axboe
