On 1/19/24 9:34 AM, Matthew Wilcox (Oracle) wrote: > Jens added unlikely() thinking that this was an error path. It's > actually just the end of the iteration, so does not warrant an > unlikely(). This is because the previous fix (or my attempt at least) didn't do the i >= vcnt, it checked for an empty bio instead. Which then definitely did make it an error/unlikely path, but obviously this one is not. The bio iterator stuff has gotten terribly unwieldy and complicated, and not very efficient either. But I guess that's a story for another investigation... -- Jens Axboe
