On 1/10/2024 6:59 AM, Jens Axboe wrote: > On 1/10/24 1:12 AM, Chaitanya Kulkarni wrote: >> >>>>> >>>>> Should this be TEST_DEV instead ? >>>> >>>> why ? >>>> >>> My understanding of blktests is, add device which we want to test in >>> config files under TEST_DEV (except null-blk and nvme-fabrics loopback >>> devices, which are usually populated inside the tests). >>> In this case, if someone do not want to disturb nvme0n1 device, >>> this test doesn't allow it. >>> >>> Regards, >>> Nitesh Shetty >>> >> >> it is clearly stated in the documentation that blktests are destructive >> to the entire system and including any devices you have, if your >> system has sensitive data then _don't run these tests_ simple, when >> you are running blktests you are bound to disturb system you can't >> prevent that by using TEST_DEV. > > It should very much be possible to run blktests on specific devices > ONLY, the intent of a test suite is not to potentially mess up > everything around you. It should ONLY operate on the devices given, not > poke at random devices in the system. > I'll make the TEST_DEV change .. -ck