On Mon, Jan 08, 2024 at 04:37:49PM +1100, Dave Chinner wrote:
> On Wed, Jan 03, 2024 at 01:54:59PM +0100, Christian Brauner wrote:
> > Signed-off-by: Christian Brauner <brauner@xxxxxxxxxx>
> > ---
> > diff --git a/include/linux/fs.h b/include/linux/fs.h
> > index 8e0d77f9464e..b0a5e94e8c3a 100644
> > --- a/include/linux/fs.h
> > +++ b/include/linux/fs.h
> > @@ -1227,8 +1227,8 @@ struct super_block {
> > #endif
> > struct hlist_bl_head s_roots; /* alternate root dentries for NFS */
> > struct list_head s_mounts; /* list of mounts; _not_ for fs use */
> > - struct block_device *s_bdev;
> > - struct bdev_handle *s_bdev_handle;
> > + struct block_device *s_bdev; /* can go away once we use an accessor for @s_f_bdev */
> > + struct file *s_f_bdev;
>
> struct file *s_bdev_file;
>
> Because then the reader knows exactly what the object type
> and what it refers to is when they read "sb->s_bdev_file" in the
> code.
Fair!
